[4.6] capsys: ensure fd is unbuffered#6062
Closed
blueyed wants to merge 1 commit into
Closed
Conversation
2 tasks
blueyed
force-pushed
the
fix-capsys-py2-4.6
branch
3 times, most recently
from
76d6927 to
46aa29e
Compare
Member
|
Tests are failing, regardless, @antocuni any chance of testing this branch for your case and see if it fixes it? |
blueyed
force-pushed
the
fix-capsys-py2-4.6
branch
from
46aa29e to
1dbd70b
Compare
blueyed
force-pushed
the
fix-capsys-py2-4.6
branch
from
1dbd70b to
cb80252
Compare
blueyed
commented
Oct 28, 2019
| # Ensure fd is unbuffered (#5134). | ||
| self._old = os.fdopen(self._old.fileno(), "wb+", 0) | ||
| except (UnsupportedOperation, OSError): | ||
| pass |
Contributor
Author
There was a problem hiding this comment.
Note that _py36_windowsconsoleio_workaround does something similar already:
Lines 804 to 816 in f7ecd72
Contributor
Author
|
I do not really feel like we should have it, since it is not required for py3 anyway, and might break other things. |
Contributor
Author
|
But FWIW tests are passing by now. |
Contributor
Author
|
I do not expect any feedback from @antocuni here (chatted with regard to the workaround he added to pyrepl). Might re-open when I look into that (pypy/pyrepl#22, pypy/pyrepl@3ff3cfa). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5134.